linux-kernel - Re: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with blk_trace_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AB86A03.7060207@cn.fujitsu.com>
Date:	Tue, 22 Sep 2009 14:09:07 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Zdenek Kabelac <zdenek.kabelac@...il.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	mbroz@...hat.com, tytso@....edu, jens.axboe@...cle.com,
	mingo@...e.hu
Subject: Re: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with
 	blk_trace_init_sysfs

Zdenek Kabelac wrote:
> Subject: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with
> blk_trace_init_sysfs
> From: Zdenek Kabelac <zkabelac@...hat.com>
> 
> Adds missing blk_trace_remove_sysfs() to be in pair with
> blk_trace_init_sysfs() introduced in commit
> 1d54ad6da9192fed5dd3b60224d9f2dfea0dcd82.
> 
> Problem was noticed via kmemleak backtrace when some sysfs entries
> were note properly destroyed during  device removal:
> 

Thanks for reporting and fixing this!

> @@ -465,6 +466,7 @@ void blk_unregister_queue(struct gendisk *disk)
> 
>  		kobject_uevent(&q->kobj, KOBJ_REMOVE);
>  		kobject_del(&q->kobj);
> +		blk_trace_remove_sysfs(disk_to_dev(disk));

This should be moved outside of 'if'.

>  		kobject_put(&disk_to_dev(disk)->kobj);
>  	}
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/