linux-kernel - Re: [GIT PULL] xen: Check NX state before setting up GDT mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090923191315.GA14437@elte.hu>
Date:	Wed, 23 Sep 2009 21:13:15 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Ingo Molnar <mingo@...hat.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Stable Kernel <stable@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Xen-devel <xen-devel@...ts.xensource.com>
Subject: Re: [GIT PULL] xen: Check NX state before setting up GDT mapping


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> On 09/23/09 05:36, Ingo Molnar wrote:
> >> +#ifdef CONFIG_X86_64
> >> +	/* Work out if we support NX */
> >> +	check_efer();
> >> +#endif
> >> +
> >>     
> > btw., this #ifdef could sure be eliminated, right?
> >   
> 
> check_efer() is only defined on x86-64 and all its existing callsites 
> have a similar #ifdef.

Yes, a familar pattern that prompted my comment.

> [...]  NX setup is an area which could do with a bit of hitting with 
> the unification stick.

Yes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/