linux-kernel - Re: [origin tree boot hang] [PATCH] Revert "early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0909231553480.3303@localhost.localdomain>
Date:	Wed, 23 Sep 2009 15:56:34 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jason Wessel <jason.wessel@...driver.com>
cc:	Ingo Molnar <mingo@...e.hu>, Len Brown <lenb@...nel.org>,
	Greg KH <gregkh@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [origin tree boot hang] [PATCH] Revert "early_printk:Allowmorethan
 one early console"



On Wed, 23 Sep 2009, Jason Wessel wrote:
> 
> Perhaps you will consider adding this patch to your tree?   It fixes the
> specific case you mentioned.  It will still allow the board to boot and
> instead of crashing, print a warning on the second instance.

Ugh. This looks totally bogus.

Why don't you just add CON_REGISTERED to the console flags, and do

	/* Already registered? */
	if (early_console->flags & CON_REGISTERED)
		return;
	early_console->flags |= CON_REGISTERED;

there instead? That whole "loop over existing consoles to check their 
names" looks silly and broken, and you're already playing with the flags 
in there (CON_BOOT).

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/