linux-kernel - Re: [PATCH] regulator: add driver for MAX8660/8661

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090924173904.GA9082@sirena.org.uk>
Date:	Thu, 24 Sep 2009 10:39:05 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...mlogic.co.uk>
Subject: Re: [PATCH] regulator: add driver for MAX8660/8661

On Thu, Sep 24, 2009 at 03:24:05PM +0200, Wolfram Sang wrote:
> Tested with a MX25-based custom board.

> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>

This looks good - thanks!  A couple of little comments below:

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

> +	if (MAX8660_DCDC_MIN_UV + selector * MAX8660_DCDC_STEP > max_uV)
> +		return -EINVAL;

Not important but using list_voltage() here would be a little nicer.

> +static struct regulator_ops max8660_dcdc_ops = {
> +	.is_enabled = max8660_dcdc_is_enabled,
> +	.list_voltage = max8660_dcdc_list,
> +	.set_voltage = max8660_dcdc_set,
> +	.get_voltage = max8660_dcdc_get,
> +	/* no set_mode() & friends: forced PWM does not save any power */

Forced PWM is normally a power loss - the benefit it gives is the
ability to respond to sudden spikes in load without voltage droops.  The
power benefit from not having it enabled is usually only apparent at
lower loads.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/