linux-kernel - RE: [PATCH 2/14] bfa: Brocade BFA FC SCSI driver (bfa1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B0A7AF226B49A14897036E9B3A68CFFECB1AB0F79B@HQ-EXCH-7.corp.brocade.com>
Date:	Thu, 24 Sep 2009 11:08:31 -0700
From:	Jing Huang <huangj@...cade.COM>
To:	Daniel Walker <dwalker@...o99.com>
CC:	"James.Bottomley@...senPartnership.com" 
	<James.Bottomley@...senPartnership.com>,
	Krishna Gudipati <kgudipat@...cade.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Ramkumar Vadivelu <rvadivel@...cade.COM>,
	Vinodh Ravindran <vravindr@...cade.COM>
Subject: RE: [PATCH 2/14] bfa: Brocade BFA FC SCSI driver (bfa1)

> > Hi Daniel,
> >
> > I did run checkpatch.pl and it didn't report any ERROR or WARNING. Do
> you use any specific flags?
> 
> No nothing special .. I run it in the following way,
> 
> ./scripts/checkpatch.pl this-is-the-test.patch
> 
> or
> 
> cat this-is-the-test.patch | ./scripts/checkpatch.pl -
> 
> how did you run it? Usually it will report something like the following
> if it finds nothing,
> 
> total: 0 errors, 0 warnings, XXX lines checked
> 
> Your patch has no obvious style problems and is ready for submission.
> 
> 
> 
> Daniel

Thanks. I found the problem. I tried the latest checkpatch in 2.6.31 and it generates a lot of ERRORs about putting parentheses for return. I have been using an older version of checkpatch for patch submission all the time, and therefore I didn't see any problem. I will fix them and resubmit the patch.

Jing 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/