linux-kernel - Re: [PATCH] perf tools: Dont use openat()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090924192002.GB19225@elte.hu>
Date:	Thu, 24 Sep 2009 21:20:02 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Fr?d?ric Weisbecker <fweisbec@...il.com>,
	Ulrich Drepper <drepper@...hat.com>,
	linux kernel <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf tools: Dont use openat()


* Eric Dumazet <eric.dumazet@...il.com> wrote:

> Ingo Molnar a ?crit :
> > * Eric Dumazet <eric.dumazet@...il.com> wrote:
> > 
> >> Hi Ingo
> >>
> >> Here is a patch for perf.
> > 
> > Applied, thanks Eric!
> > 
> >> BTW, use of openat() is a nuisance, since many machines have old glibc
> >> (RHEL 4 Update 5 -> glibc-2.3.4-2.36 on my dev machine for example)
> > 
> > We can certainly remove that reliance - wanna send a patch for it?
> 
> Here it is
> 
> Thanks
> 
> [PATCH] perf tools: Dont use openat()
> 
> openat() is still a young glibc facility, better to not use it
> in a non performance critical program (perf list)
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> ---
>  tools/perf/util/parse-events.c |   49 ++++++++++++-------------------
>  1 files changed, 20 insertions(+), 29 deletions(-)

Applied, thanks Eric! I think it's also significant enough to be pushed 
to 2.6.32.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/