linux-kernel - Re: [PATCH] module: Fix up CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200909251724.21416.rusty@rustcorp.com.au>
Date:	Fri, 25 Sep 2009 17:24:20 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	Paul Mundt <lethal@...ux-sh.org>,
	Jan Beulich <jbeulich@...ell.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: Fix up CONFIG_KALLSYMS=n build.

On Fri, 25 Sep 2009 04:19:22 pm Américo Wang wrote:
> On Fri, Sep 25, 2009 at 11:45 AM, Paul Mundt <lethal@...ux-sh.org> wrote:
> > Starting from commit 4a4962263f07d14660849ec134ee42b63e95ea9a
> > "reduce symbol table for loaded modules (v2)", the kernel/module.c build
> > is broken with CONFIG_KALLSYMS disabled.
> >
> >  CC      kernel/module.o
> > kernel/module.c:1995: warning: type defaults to 'int' in declaration of 'Elf_Hdr'
> > kernel/module.c:1995: error: expected ';', ',' or ')' before '*' token
> > kernel/module.c: In function 'load_module':
> > kernel/module.c:2203: error: 'strmap' undeclared (first use in this function)
> > kernel/module.c:2203: error: (Each undeclared identifier is reported only once
> > kernel/module.c:2203: error: for each function it appears in.)
> > kernel/module.c:2239: error: 'symoffs' undeclared (first use in this function)
> > kernel/module.c:2239: error: implicit declaration of function 'layout_symtab'
> > kernel/module.c:2240: error: 'stroffs' undeclared (first use in this function)
> > make[1]: *** [kernel/module.o] Error 1
> > make: *** [kernel/module.o] Error 2
> >
> > There are three different issues:
> >
> >    - layout_symtab() takes a const Elf_Ehdr
> >
> >    - layout_symtab() needs to return a value
> >
> >    - symoffs/stroffs/strmap are referenced by the load_module() code
> >      despite being ifdefed out, which seems unnecessary given the noop
> >      behaviour of layout_symtab()/add_kallsyms() in the case of
> >      CONFIG_KALLSYMS=n.
> >
> > Signed-off-by: Paul Mundt <lethal@...ux-sh.org>
> > Cc: Jan Beulich <jbeulich@...ell.com>
> > Cc: Rusty Russell <rusty@...tcorp.com.au>
> 
> Indeed.
> 
> Acked-by: WANG Cong <amwang@...hat.com>

And this completes the set:

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Thanks Paul!

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/