linux-kernel - Re: [PATCH] ACPI: Kill overly verbose "power state" log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253839597.3609.459.camel@localhost.localdomain>
Date:	Fri, 25 Sep 2009 08:46:37 +0800
From:	ykzhao <yakui.zhao@...el.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Len Brown <lenb@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH] ACPI: Kill overly verbose "power state" log messages

On Fri, 2009-09-25 at 05:52 +0800, Roland Dreier wrote:
> I was recently lucky enough to get a 64-CPU system.  The processors
> actually have T-states, so my kernel log ends up with 64 lines like:
> 
>     ACPI: CPU0 (power states: C1[C1] C2[C3])
> 
> This is pretty useless clutter because this info is already available
> after boot from both /sys/devices/system/cpu/cpu*/cpuidle/state?/ as
> well as /proc/acpi/processor/CPU*/power.
> 
> So just delete the code that prints the throttling states in
> processor_idle.c.
It seems that it is unnecessary to delete the C-state info.
Thanks.
> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>
> ---
>  drivers/acpi/processor_idle.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index cc61a62..706eacf 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -1214,13 +1214,6 @@ int __cpuinit acpi_processor_power_init(struct acpi_processor *pr,
>  		acpi_processor_setup_cpuidle(pr);
>  		if (cpuidle_register_device(&pr->power.dev))
>  			return -EIO;
> -
> -		printk(KERN_INFO PREFIX "CPU%d (power states:", pr->id);
> -		for (i = 1; i <= pr->power.count; i++)
> -			if (pr->power.states[i].valid)
> -				printk(" C%d[C%d]", i,
> -				       pr->power.states[i].type);
> -		printk(")\n");
>  	}
>  #ifdef CONFIG_ACPI_PROCFS
>  	/* 'power' [R] */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/