linux-kernel - Re: [PATCH 17/63] edac_mce: Add an interface driver to report mce errors via edac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090925144720.38ea1c1f@infradead.org>
Date:	Fri, 25 Sep 2009 14:47:20 +0200
From:	Arjan van de Ven <arjan@...radead.org>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Borislav Petkov <borislav.petkov@....com>,
	bluesmoke-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 17/63] edac_mce: Add an interface driver to report mce
 errors via edac

On Fri, 25 Sep 2009 09:11:30 -0300
Mauro Carvalho Chehab <mchehab@...hat.com> wrote:

> 5) there are very few calls to kernel routines here:
> list_for_each_entry(), spin_lock_irqsave(), in_unlock_irqrestore(),
> memcpy(). I don't think any of them will have any problems on working
> even inside NMI context.

spinlocks in NMI context don't do what you think they do....
_irqsave does not disable NMIs so this can deadlock.

You likely want to use trylock here....


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/