linux-kernel - Re: [GIT PULL] tracing fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090926161034.GA17279@lst.de>
Date:	Sat, 26 Sep 2009 18:10:34 +0200
From:	Christoph Hellwig <hch@....de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Hellwig <hch@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Fr??d??ric Weisbecker <fweisbec@...il.com>
Subject: Re: [GIT PULL] tracing fixes

On Mon, Sep 21, 2009 at 06:22:11PM +0200, Ingo Molnar wrote:
> Hm, yes, you are right, we missed that. I noticed the modpost 
> dependency:
> 
>   http://marc.info/?l=linux-kernel&m=125326944223679&w=2
> 
> but thought that it's safe and didnt notice that dangling 
> module_layout() reference and the build warning it generates in the 
> kernel.
> 
> I _think_ the patch below should do the trick - module_layout() appears 
> to be an artificial symbol with 'significant' symbols listed in its 
> argument list so that it gets a proper signature. Removing the marker 
> symbol should thus be the solution, but i'm not 100% sure. Thoughts?
> 
> 	Ingo

Looks good to me, Linus?

> diff --git a/kernel/module.c b/kernel/module.c
> index b6ee424..392eb3d 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2947,7 +2947,6 @@ void module_layout(struct module *mod,
>  		   struct modversion_info *ver,
>  		   struct kernel_param *kp,
>  		   struct kernel_symbol *ks,
> -		   struct marker *marker,
>  		   struct tracepoint *tp)
>  {
>  }
---end quoted text---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/