linux-kernel - Re: [origin tree build failure] Re: [PULL] Please pull hwpoison code for 2.6.32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090926172802.GS30185@one.firstfloor.org>
Date:	Sat, 26 Sep 2009 19:28:02 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...e.hu>,
	torvalds@...ux-foundation.org, fengguang.wu@...el.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [origin tree build failure] Re: [PULL] Please pull hwpoison code for 2.6.32

On Sat, Sep 26, 2009 at 10:20:05AM -0700, H. Peter Anvin wrote:
> It doesn't help adjusting NODES_SHIFT - we're already operating in the stressed condition for which NODES_WIDTH == 0 (external node number.)
> 
> As such, NUMA vs !NUMA is a red herring - it's really about SPARSEMEM.
> 
> (Disclaimer: I have no access to the code at the moment and I only have my cell phone email, but I had to deal with this for another issue recently enough.)

You're right. In theory we could just set the sparsemem block really
large on NUMAQ because it doesn't support memory hotadd anyways, so needing
less bits.  But Linus' simple patch is also a solution.

Of course the issue might come up again when someone else needs another
page flags bit.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/