linux-kernel - Re: [PATCH] x86: Fix hwpoison code related build failure on 32-bit NUMAQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0909261038510.3303@localhost.localdomain>
Date:	Sat, 26 Sep 2009 10:43:37 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Andi Kleen <andi@...stfloor.org>, fengguang.wu@...el.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] x86: Fix hwpoison code related build failure on 32-bit
 NUMAQ



On Sat, 26 Sep 2009, Ingo Molnar wrote:
> >  
> > +config X86_SUPPORTS_MEMORY_FAILURE
> > +	bool
> > +	depends on !X86_NUMAQ
> > +	select ARCH_SUPPORTS_MEMORY_FAILURE
> > +	default y
> 
> Thanks Linus, this patch fixed the NUMAQ build problem.

I think it's slightly buggy still.

I think the X86_SUPPORTS_MEMORY_FAILURE thing should also have a

	depends on X86_MCE

line, because we still depend on MCE.

And as you found out, there's also the sparsemem thing.

Don't make it one huge ugly thing, just split out the requirements like

	depends on X86_MCE
	depends on !X86_NUMAQ
	depends on X86_64 || !SPARSEMEM

because I think the requirements are fairly independent, and it makes it 
easier to read (you could even comment each line on why _that_ particular 
issue needs to disable X86_SUPPORTS_MEMORY_FAILURE)

But yeah, with that, and some testing, please add my sign-off (or 
acked-by, if you end up changing the patch so much that it has little to 
do with my original one)

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/