| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090926205025.3befecf6@infradead.org> Date: Sat, 26 Sep 2009 20:50:25 +0200 From: Arjan van de Ven <arjan@...radead.org> To: Arjan van de Ven <arjan@...radead.org> Cc: linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org, mingo@...e.hu, lenb@...nel.org Subject: [PATCH 1/9] Fix bound checks for copy_from_user in the acpi /proc code From: Arjan van de Ven <arjan@...ux.intel.com> Subject: [PATCH 1/9] Fix bound checks for copy_from_user in the acpi /proc code CC: Len Brown <lenb@...nel.org> The ACPI /proc write() code takes an unsigned length argument like any write() function, but then assigned it to a *signed* integer called "len". Only after this is a sanity check for len done to make it not larger than 4. Due to the type change a len < 0 is in principle also possible; this patch adds a check for this. Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com> diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c index d0d550d..f8b6f55 100644 --- a/drivers/acpi/proc.c +++ b/drivers/acpi/proc.c @@ -398,6 +398,8 @@ acpi_system_write_wakeup_device(struct file *file, if (len > 4) len = 4; + if (len < 0) + return -EFAULT; if (copy_from_user(strbuf, buffer, len)) return -EFAULT; -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists