linux-kernel - Re: [PATCH] linux-next: 20090926 - drop autoconf.h from DRBD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090926200839.GA5220@merkur.ravnborg.org>
Date:	Sat, 26 Sep 2009 22:08:39 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-kbuild@...r.kernel.org, sfr@...b.auug.org.au
Subject: Re: [PATCH] linux-next: 20090926 - drop autoconf.h from DRBD driver

On Sat, Sep 26, 2009 at 11:01:43PM +0530, Kamalesh Babulal wrote:
> Hi Sam,
> 
> 	next-20090926 allyesconfig build breaks on powerpc,
> 
> drivers/block/drbd/drbd_proc.c:26:28: error: linux/autoconf.h: No such file or directory
> make[3]: *** [drivers/block/drbd/drbd_proc.o] Error 1
> 
> dropping autoconf.h from drbd_proc.c helps. The cleanup patch drops the
> unneeded include autoconf.h.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>

I only checked upstream - so this is no big suprise.
As there is no need to explicitly include autoconf.h this
change should be included by the drdb folks even if the
stuff I have does not hit upstream.

Can I ask you to audit the rest of -next for similar issues.
A 'git grep "autoconf\.h"' should be a qucik way to find other
spots to fix up.

Patch is:

Acked-by: Sam Ravnborg <sam@...nborg.org>

	Sam

> --
>  drivers/block/drbd/drbd_main.c     |    1 -
>  drivers/block/drbd/drbd_nl.c       |    1 -
>  drivers/block/drbd/drbd_proc.c     |    1 -
>  drivers/block/drbd/drbd_receiver.c |    1 -
>  drivers/block/drbd/drbd_req.c      |    1 -
>  drivers/block/drbd/drbd_req.h      |    1 -
>  drivers/block/drbd/drbd_worker.c   |    1 -
>  drivers/staging/cowloop/cowloop.c  |    4 ----
>  drivers/staging/iio/ring_sw.h      |    1 -
>  9 files changed, 0 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
> index edf0b80..80273f2 100644
> --- a/drivers/block/drbd/drbd_main.c
> +++ b/drivers/block/drbd/drbd_main.c
> @@ -26,7 +26,6 @@
>  
>   */
>  
> -#include <linux/autoconf.h>
>  #include <linux/module.h>
>  #include <linux/version.h>
>  #include <linux/drbd.h>
> diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
> index 1927ace..cfde310 100644
> --- a/drivers/block/drbd/drbd_nl.c
> +++ b/drivers/block/drbd/drbd_nl.c
> @@ -23,7 +23,6 @@
>  
>   */
>  
> -#include <linux/autoconf.h>
>  #include <linux/module.h>
>  #include <linux/drbd.h>
>  #include <linux/in.h>
> diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
> index 98fcb74..bdd0b49 100644
> --- a/drivers/block/drbd/drbd_proc.c
> +++ b/drivers/block/drbd/drbd_proc.c
> @@ -23,7 +23,6 @@
>  
>   */
>  
> -#include <linux/autoconf.h>
>  #include <linux/module.h>
>  
>  #include <asm/uaccess.h>
> diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
> index 63686c4..2f81821 100644
> --- a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -23,7 +23,6 @@
>   */
>  
>  
> -#include <linux/autoconf.h>
>  #include <linux/module.h>
>  
>  #include <asm/uaccess.h>
> diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
> index 0656cf1..1aaa397 100644
> --- a/drivers/block/drbd/drbd_req.c
> +++ b/drivers/block/drbd/drbd_req.c
> @@ -23,7 +23,6 @@
>  
>   */
>  
> -#include <linux/autoconf.h>
>  #include <linux/module.h>
>  
>  #include <linux/slab.h>
> diff --git a/drivers/block/drbd/drbd_req.h b/drivers/block/drbd/drbd_req.h
> index d37ab57..f22c1bc 100644
> --- a/drivers/block/drbd/drbd_req.h
> +++ b/drivers/block/drbd/drbd_req.h
> @@ -25,7 +25,6 @@
>  #ifndef _DRBD_REQ_H
>  #define _DRBD_REQ_H
>  
> -#include <linux/autoconf.h>
>  #include <linux/module.h>
>  
>  #include <linux/slab.h>
> diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
> index 212e954..34a4b3e 100644
> --- a/drivers/block/drbd/drbd_worker.c
> +++ b/drivers/block/drbd/drbd_worker.c
> @@ -23,7 +23,6 @@
>  
>   */
>  
> -#include <linux/autoconf.h>
>  #include <linux/module.h>
>  #include <linux/version.h>
>  #include <linux/drbd.h>
> diff --git a/drivers/staging/cowloop/cowloop.c b/drivers/staging/cowloop/cowloop.c
> index a71c743..a21b9b4 100644
> --- a/drivers/staging/cowloop/cowloop.c
> +++ b/drivers/staging/cowloop/cowloop.c
> @@ -237,10 +237,6 @@ char revision[] = "$Revision: 3.1 $"; /* cowlo_init_module() has
>  #endif
>  
>  #include <linux/types.h>
> -#include <linux/autoconf.h>
> -#ifndef AUTOCONF_INCLUDED
> -#include <linux/config.h>
> -#endif
>  #include <linux/module.h>
>  #include <linux/version.h>
>  #include <linux/moduleparam.h>
> diff --git a/drivers/staging/iio/ring_sw.h b/drivers/staging/iio/ring_sw.h
> index ae70ee0..4b0de7c 100644
> --- a/drivers/staging/iio/ring_sw.h
> +++ b/drivers/staging/iio/ring_sw.h
> @@ -29,7 +29,6 @@
>   * driver requests - some may support multiple options */
>  
>  
> -#include <linux/autoconf.h>
>  #include "iio.h"
>  #include "ring_generic.h"
>  
> 			
> 			Kamalesh
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/