linux-kernel - Re: [linux-pm] [PATCH, fix] Re: [Regression] 2.6.31-git: tty change broke resume from hibernation on MSI Wind U100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0909271329400.5871-100000@netrider.rowland.org>
Date:	Sun, 27 Sep 2009 13:32:31 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, Greg KH <gregkh@...e.de>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Young <hidave.darkstar@...il.com>
Subject: Re: [linux-pm] [PATCH, fix] Re: [Regression] 2.6.31-git: tty change
 broke resume from hibernation on MSI Wind U100

On Sun, 27 Sep 2009, Rafael J. Wysocki wrote:

> Tested, works.
> 
> Greg, could you please consider taking the patch below?  It fixes a recent
> hibernation regression for me, so if not this one, another fix is necessary.

This patch has a mistake.

> Index: linux-2.6/drivers/usb/serial/usb-serial.c
> ===================================================================
> --- linux-2.6.orig/drivers/usb/serial/usb-serial.c
> +++ linux-2.6/drivers/usb/serial/usb-serial.c
> @@ -1210,7 +1210,7 @@ static const struct tty_operations seria
>  	.chars_in_buffer =	serial_chars_in_buffer,
>  	.tiocmget =		serial_tiocmget,
>  	.tiocmset =		serial_tiocmset,
> -	.shutdown = 		serial_release,
> +	.cleanup = 		serial_release,
>  	.install = 		serial_install,
>  	.proc_fops =		&serial_proc_fops,
>  };

It isn't enough to change the method pointer.  The code in 
serial_release() has to be changed too; it must not call tty_shutdown() 
any more.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/