lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090927182149.GA23464@hiauly1.hia.nrc.ca>
Date:	Sun, 27 Sep 2009 14:21:50 -0400
From:	John David Anglin <dave@...uly1.hia.nrc.ca>
To:	Julia Lawall <julia@...u.dk>
Cc:	Helge Deller <deller@....de>, Kyle McMartin <kyle@...artin.ca>,
	linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] arch/parisc: correct use of SHF_ALLOC

Hi Kyle,

I noticed today that this change is not in 2.6.31.1.

Dave

On Tue, 04 Aug 2009, Julia Lawall wrote:

> From: Julia Lawall <julia@...u.dk>
> 
> SHF_ALLOC is suitable for testing against the sh_flags field, not the
> sh_type field.
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  arch/parisc/kernel/module.c         |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c
> index ef5caf2..c904817 100644
> --- a/arch/parisc/kernel/module.c
> +++ b/arch/parisc/kernel/module.c
> @@ -853,7 +853,7 @@ int module_finalize(const Elf_Ehdr *hdr,
>  	 * ourselves */
>  	for (i = 1; i < hdr->e_shnum; i++) {
>  		if(sechdrs[i].sh_type == SHT_SYMTAB
> -		   && (sechdrs[i].sh_type & SHF_ALLOC)) {
> +		   && (sechdrs[i].sh_flags & SHF_ALLOC)) {
>  			int strindex = sechdrs[i].sh_link;
>  			/* FIXME: AWFUL HACK
>  			 * The cast is to drop the const from
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
J. David Anglin                                  dave.anglin@...-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ