linux-kernel - Re: [PATCH] xtensa: Remove unused CONFIG XTENSA_ISS_NETWORK and XTENSA_UNALIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090927085227.GA8022@cmpxchg.org>
Date:	Sun, 27 Sep 2009 10:52:27 +0200
From:	Johannes Weiner <hannes@...xchg.org>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Johannes Weiner <jw@...ix.com>, Chris Zankel <chris@...kel.net>,
	"Robert P. J. Day" <rpjday@...shcourse.ca>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xtensa: Remove unused CONFIG XTENSA_ISS_NETWORK and XTENSA_UNALIGNED_USER

On Sat, Sep 26, 2009 at 10:23:19PM +0530, Jaswinder Singh Rajput wrote:
> 
> Removed unused CONFIG XTENSA_ISS_NETWORK and XTENSA_UNALIGNED_USER from Kconfig and defconfigs
> 
> Reported-by: Robert P. J. Day <rpjday@...shcourse.ca>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> Cc: Johannes Weiner <jw@...ix.com>
> Cc: Chris Zankel <chris@...kel.net>
> ---
>  arch/xtensa/Kconfig                 |   13 -------------
>  arch/xtensa/configs/iss_defconfig   |    2 --
>  arch/xtensa/configs/s6105_defconfig |    2 --
>  3 files changed, 0 insertions(+), 17 deletions(-)
> 
> diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig
> index ebe228d..328d0dd 100644
> --- a/arch/xtensa/Kconfig
> +++ b/arch/xtensa/Kconfig
> @@ -83,15 +83,6 @@ config XTENSA_VARIANT_S6000
>  	select XTENSA_CALIBRATE_CCOUNT
>  endchoice
>  
> -config XTENSA_UNALIGNED_USER

The code refers to CONFIG_UNALIGNED_USER, so a rename would be better
instead of removing it.

> -	bool "Unaligned memory access in use space"
> -	help
> -	  The Xtensa architecture currently does not handle unaligned
> -	  memory accesses in hardware but through an exception handler.
> -	  Per default, unaligned memory accesses are disabled in user space.
> -
> -	  Say Y here to enable unaligned memory access in user space.
> -
>  config PREEMPT
>  	bool "Preemptible Kernel"
>  	help
> @@ -122,9 +113,6 @@ config XTENSA_CALIBRATE_CCOUNT
>  config SERIAL_CONSOLE
>  	def_bool n
>  
> -config XTENSA_ISS_NETWORK
> -	def_bool n
> -

That one is of no use in the mainline kernel.  I guess out-of-tree
code uses it.

>  menu "Bus options"
>  
>  config PCI
> @@ -150,7 +138,6 @@ config XTENSA_PLATFORM_ISS
>  	bool "ISS"
>  	select XTENSA_CALIBRATE_CCOUNT
>  	select SERIAL_CONSOLE
> -	select XTENSA_ISS_NETWORK
>  	help
>  	  ISS is an acronym for Tensilica's Instruction Set Simulator.
>  
> diff --git a/arch/xtensa/configs/iss_defconfig b/arch/xtensa/configs/iss_defconfig
> index f198540..e6c1a29 100644
> --- a/arch/xtensa/configs/iss_defconfig
> +++ b/arch/xtensa/configs/iss_defconfig

No need to edit auto-generated files.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/