linux-kernel - Re: [patch 03/33] fs: scale files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1254144139.15795.4.camel@laptop>
Date:	Mon, 28 Sep 2009 15:22:19 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	npiggin@...e.de
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 03/33] fs: scale files_lock

On Fri, 2009-09-04 at 16:51 +1000, npiggin@...e.de wrote:
> +static void file_list_lock_all(void)
> +{
> +       int i;
> +       int nr = 0;
> +
> +       for_each_possible_cpu(i) {
> +               spinlock_t *lock;
> +
> +               lock = &per_cpu(files_cpulock, i);
> +               spin_lock_nested(lock, nr);
> +               nr++;
> +       }
> +}

Same here, this'll make lockdep explode on >8-way. And create large spin
times on large smp boxen.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/