linux-kernel - Re: [PATCH] Remove pty_ops_bsd and pty_bsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090928151628.62955233@lxorguk.ukuu.org.uk>
Date:	Mon, 28 Sep 2009 15:16:28 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...ux-foundation.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not
 used

On Mon, 28 Sep 2009 14:53:32 +0100
David Howells <dhowells@...hat.com> wrote:

> Remove pty_ops_bsd as nothing appears to use it anymore.  It results in the
> following warning:
> 
> 	drivers/char/pty.c:344: warning: unused variable `pty_ops_bsd'
> 
> if CONFIG_LEGACY_PTYS=y.
> 
> Also remove pty_bsd_ioctl() as that's only referred to by pty_ops_bsd.
> 
> Possibly legacy_pty_init() should be passing this to tty_set_operations()
> rather than pty_ops.

It should indeed, otherwise the BSD pty locking ioctl fails.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/