linux-kernel - Re: [PATCH] percpu: fix unit_map[] verification in pcpu_setup_first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1254175662.2783.1.camel@localhost>
Date:	Mon, 28 Sep 2009 23:07:42 +0100
From:	Tony Vroon <tony@...x.net>
To:	Tejun Heo <tj@...nel.org>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] percpu: fix unit_map[] verification in
 pcpu_setup_first_chunk()

On Tue, 2009-09-29 at 01:19 +0900, Tejun Heo wrote:
> pcpu_setup_first_chunk() incorrectly used NR_CPUS as the impossible
> unit number while unit number can equal and go over NR_CPUS with
> sparse unit map.  This triggers BUG_ON() spuriously on machines which
> have non-power-of-two number of cpus.  Use UINT_MAX instead.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Tony Vroon <tony@...x.net>
Tested-by: Tony Vroon <tony@...x.net>

> Erghh... stupid mistake.  This should fix it.  Can you please verify?

Confirmed fixed. Thank you Tejun.

Regards,
Tony V.

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)