linux-kernel - Re: Updated: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl7225b.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1254176318.28232.388.camel@Joe-Laptop.home>
Date:	Mon, 28 Sep 2009 15:18:38 -0700
From:	Joe Perches <joe@...ches.com>
To:	Bruce Jones <brucej97223@...il.com>
Cc:	gregkh@...e.de, wfp5@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: Updated: [PATCH] staging: comedi: CodingStyle cleanup for
 drivers/acl7225b.c

On Mon, 2009-09-28 at 15:10 -0700, Bruce Jones wrote:
> Cleanup the printk's in this driver to use KERN_foo log
> levels.
> +	printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
>  	       this_board->name, iobase);
>  	if (!request_region(iobase, iorange, "acl7225b")) {
> -		printk("I/O port conflict\n");
> +		printk(KERN_CONT "I/O port conflict\n");

This should not be KERN_CONT but KERN_INFO or KERN_ERR
and should probably have a "comedi%d:" leader.

Maybe:
	printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n");

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/