[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1254133004-24877-1-git-send-email-21cnbao@gmail.com>
Date: Mon, 28 Sep 2009 18:16:44 +0800
From: Barry Song <21cnbao@...il.com>
To: akpm@...ux-foundation.org, davem@...emloft.net,
patrick.ohly@...el.com
CC: uclinux-dist-devel@...ckfin.uclinux.org,
linux-kernel@...r.kernel.org, Barry Song <21cnbao@...il.com>
Subject: [PATCH] Fix half-Y2K38 problem in timecompare_update while calculating offset
ktime will overflow from 03:14:07 UTC on Tuesday, 19 January 2038,
ktime_add() in timecompare_update() will overflow a half earlier.
As a result, wrong offset will be gotten, then cause some strange
problems.
---
kernel/time/timecompare.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/time/timecompare.c b/kernel/time/timecompare.c
index 71e7f1a..d2d893e 100644
--- a/kernel/time/timecompare.c
+++ b/kernel/time/timecompare.c
@@ -89,7 +89,7 @@ int timecompare_offset(struct timecompare *sync,
* source time
*/
sample.offset =
- ktime_to_ns(ktime_add(end, start)) / 2 -
+ (ktime_to_ns(end) + ktime_to_ns(start)) / 2 -
ts;
/* simple insertion sort based on duration */
--
1.5.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists