linux-kernel - Re: [PATCH] USB: digi_acceleport: Fix broken unthrottle.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090929113518.GE2152@localhost>
Date:	Tue, 29 Sep 2009 13:35:18 +0200
From:	Johan Hovold <jhovold@...il.com>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	Johan Hovold <jhovold@...il.com>,
	Peter Berger <pberger@...mson.com>,
	Al Borchers <alborchers@...inerpoint.com>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: digi_acceleport: Fix broken unthrottle.

On Tue, Sep 29, 2009 at 01:20:44PM +0200, Oliver Neukum wrote:
> Am Dienstag, 29. September 2009 12:39:23 schrieb Johan Hovold:
> > This patch is untested as I haven't got the hardware, but seems
> > straight-forward to me.
> >
> > Can you verify, Oliver?
> 
> I would prefer to see a check in usb-serial.c::serial_unthrottle()

This is completely unrelated to the unthrottle issue discussed elsewhere. :)

The digi_acceleport unthrottle code should (and used to) check
priv->dp_throttle_restart to determine whether to resubmit and then
cleared the flag. The commit mentioned mistakenly, I assume, reversed this.
Plain bug. Right?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/