[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090929145413.GA26327@ioremap.net>
Date: Tue, 29 Sep 2009 18:54:13 +0400
From: Evgeniy Polyakov <zbr@...emap.net>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Christian Borntraeger <borntraeger@...ibm.com>,
Evgeny Polyakov <johnpol@....mipt.ru>,
Scott James Remnant <scott@...ntu.com>,
Linux Kernel <linux-kernel@...r.kernel.org>,
Matt Helsley <matthltc@...ibm.com>,
"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...)
On Tue, Sep 29, 2009 at 04:25:38PM +0200, Oleg Nesterov (oleg@...hat.com) wrote:
> > --- a/kernel/sys.c
> > +++ b/kernel/sys.c
> > @@ -1090,6 +1090,7 @@ SYSCALL_DEFINE0(setsid)
> > struct pid *sid = task_pid(group_leader);
> > pid_t session = pid_vnr(sid);
> > int err = -EPERM;
> > + int send_cn = 0;
> >
> > write_lock_irq(&tasklist_lock);
> > /* Fail if I am already a session leader */
> > @@ -1104,12 +1105,18 @@ SYSCALL_DEFINE0(setsid)
> >
> > group_leader->signal->leader = 1;
> > __set_special_pids(sid);
> > + if (task_session(group_leader) != sid)
> > + send_cn = 1;
>
> This is not right, task_session(group_leader) must be == sid after
> __set_special_pids().
Yeah, that check should be done before __set_special_pids().
> And I don't think "int send_cn" is needed. sys_setsid() must not
> succeed if the caller lived in session == task_pid(group_leader).
Doesn't it only check pgid while patch intention was to send
notification about sid? I.e. setsid() succeeds, although nothing
happens.
--
Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists