lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Sep 2009 10:06:57 +0200 From: Frederic Weisbecker <fweisbec@...il.com> To: John Kacur <jkacur@...hat.com> Cc: mingo@...e.hu, Peter Zijlstra <a.p.zijlstra@...llo.nl>, linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org Subject: Re: [PATCH] Put common histogram functions for perf in their own file On Mon, Sep 28, 2009 at 05:04:07PM +0200, John Kacur wrote: > perf annotate still will not sort the entries with these changes. > because callchain will be equal to zero. The sorting does not only applies to callchains but also on histogram entries. > Calling output__resort(total) will be harmless because the calculation > will be thrown away in output__insert_entry() here: > if (callchain) > callchain_param.sort(&he->sorted_chain, &he->callchain, > min_callchain_hits, &callchain_param); Hmm, but the histogram entries will still be sorted, I might be wrong but it doesn't seem to be needed. That said it's not something introduced by your patch, it was already there, but I guess it would be a nice separate cleanup patch. > From 7c6a2035c32d17db0e566a36c7e345ec2182f722 Mon Sep 17 00:00:00 2001 > From: John Kacur <jkacur@...hat.com> > Date: Mon, 28 Sep 2009 14:53:08 +0200 > Subject: [PATCH] Put common histogram functions for perf in their own file > > Move histogram related functions into their own files (hist.c and hist.h) > and make use of them in builtin-annotate.c and builtin-report.c > > Signed-off-by: John Kacur <jkacur@...hat.com> Acked-by: Frederic Weisbecker <fweisbec@...il.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists