linux-kernel - Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AC37E81.8080104@redhat.com>
Date:	Wed, 30 Sep 2009 05:51:29 -1000
From:	Zachary Amsden <zamsden@...hat.com>
To:	Avi Kivity <avi@...hat.com>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marcelo Tosatti <mtosatti@...hat.com>
Subject: Re: [PATCH v4: kvm 1/4] Code motion.  Separate timer intialization
 into an indepedent function.

On 09/29/2009 10:45 PM, Avi Kivity wrote:
> On 09/29/2009 11:38 PM, Zachary Amsden wrote:
>> Signed-off-by: Zachary Amsden<zamsden@...hat.com>
>
>
> Looks good.
>
> Is anything preventing us from unifying the constant_tsc and !same 
> paths?  We could just do a quick check in the notifier, see the tsc 
> frequency hasn't changed, and return.

Actually, yes.  On constant_tsc processors, the processor frequency may 
still change, however the TSC frequency does not change with it.

I actually have both of these kinds of processors (freq changes with 
constant TSC and freq changes with variable TSC) so I was able to test 
both of these cases.

Zach
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/