linux-kernel - Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AC38340.4000305@redhat.com>
Date:	Wed, 30 Sep 2009 18:11:44 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Zachary Amsden <zamsden@...hat.com>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marcelo Tosatti <mtosatti@...hat.com>
Subject: Re: [PATCH v4: kvm 1/4] Code motion.  Separate timer intialization
 into an indepedent function.

On 09/30/2009 06:06 PM, Zachary Amsden wrote:
> On 09/30/2009 05:56 AM, Avi Kivity wrote:
>> On 09/30/2009 05:51 PM, Zachary Amsden wrote:
>>
>> If the API allows us to query the tsc frequency, it would simply 
>> return the same values in all cases, which we'd ignore.
>
> The API only allows querying the processor frequency.  In the 
> constant_tsc case, the highest processor frequency is likely going to 
> be the actual TSC frequency, but I don't think it's a guarantee; 
> theoretically, it could be faster on normal hardware ... or slower on 
> overclocked hardware with an externally clocked TSC.

Well we could add a new API then (or a new tscfreq notifier).  Those 
conditionals don't belong in client code.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/