linux-kernel - Re: [PATCH] cmpc_acpi: Added support for Classmate PC ACPI devices.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090930175141.GG17475@vespa.holoscopio.com>
Date:	Wed, 30 Sep 2009 14:51:43 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
Cc:	linux-kernel@...r.kernel.org, len.brown@...el.com, don@...t.com.br,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH] cmpc_acpi: Added support for Classmate PC ACPI devices.

On Wed, Sep 30, 2009 at 09:50:38AM -0600, Bjorn Helgaas wrote:
> On Monday 28 September 2009 07:38:00 pm Thadeu Lima de Souza Cascardo wrote:
> > This add supports for devices like keyboard, backlight, tablet and
> > accelerometer.
> 
> Something about the PNP IDs bothered me yesterday, but I couldn't
> figure out what.  You're using:
> 
>   ACCE0000
>   TBLT0000
>   IPML200
>   FnBT0000
> 
> Normally these OEM-specific ACPI drivers claim PNP IDs like ATK0100,
> TOS6200, FUJ02B1, etc., that are obviously OEM-specific.
> 
> But the ones you're claiming seem pretty generic, like things
> we could imagine appearing on machines other than the Classmate.
> 
> So I guess my question is, "Are these really generic?  If so, should
> this be split into separate, non-Classmate named drivers, such as
> 'accelerometer', 'tablet', etc.?"
> 

Although I agree that {ATK,TOS,FUJ,IBM}* give pretty much a certainty
these are OEM-specific, I think we'd need some evidence that
{ACCE,TBLT,IPML,FnBT}* are generic enough to grant them a non-classmate
driver.

What I mean is that we should push this driver forward and turn these
into a generic driver if we get some evidence these are not
Classmate-specific. And that will happen when we hit some other system
with these devices.

And what would be the consequences to this decision? Renaming the
driver, changing the config location and documentation. Splitting them.
I can't think of anything else. If splitting them would be interesting
by now, we can do it.

That's my opinion. Please, tell me what you think of it.

> Bjorn
> 

Thanks for the comments and best regards,
Cascardo.

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)