linux-kernel - Re: [PATCH] USB: ftdi_sio: Remove tty->low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AC2FBBA.9070307@gandalf.sssup.it>
Date:	Wed, 30 Sep 2009 08:33:30 +0200
From:	Michael Trimarchi <trimarchi@...dalf.sssup.it>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Johan Hovold <jhovold@...il.com>,
	Oliver Neukum <oliver@...kum.org>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: ftdi_sio: Remove tty->low_latency.

Alan Cox wrote:
>> As it stands today ftdi_sio does indeed call tty_flip_buffer_push from
>> interrupt context with low_latency set and that is obviously incorrect,
>> right?
>>     
>
> It seems to do it from a work queue - or did I miss a case ?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>   
  usb_fill_bulk_urb(port->read_urb, dev,
                        usb_rcvbulkpipe(dev, port->bulk_in_endpointAddress),
                        port->read_urb->transfer_buffer,
                                port->read_urb->transfer_buffer_length,
                        ftdi_read_bulk_callback, port);

  (can be call in the interrupt context)
  ftdi_read_bulk_callback--->
                            ftdi_process_read-->      
                                                tty_flip_buffer_push(tty);
                                               
                                               

Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/