linux-kernel - Re: [PATCH] generate-cmdlist.sh should be either executable or run as parameter of "."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091001081102.GF7733@elte.hu>
Date:	Thu, 1 Oct 2009 10:11:02 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Mulyadi Santosa <mulyadi.santosa@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, mingo@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] generate-cmdlist.sh should be either executable or run
	as parameter of "."


* Sam Ravnborg <sam@...nborg.org> wrote:

> On Wed, Sep 30, 2009 at 02:08:22PM +0200, Ingo Molnar wrote:
> > 
> > * Mulyadi Santosa <mulyadi.santosa@...il.com> wrote:
> > 
> > > I believe this is just a small glitch. generate-cmdlist.sh by default 
> > > should be made as executable. But since one might forgot to do it, we 
> > > could simply call it as an argument "." or "source" or even "sh -c". I 
> > > pick "."
> > > 
> > > Tested in 2.6.31
> > > 
> > > Signed-off-by: Mulyadi Santosa <mulyadi.santosa@...il.com>
> > 
> > hm, generate-cmdlist.sh is executable in the upstream kernel repo. It 
> > apparently isnt executable on your box - why?
> 
> Whatever - we should try to avoid relying on executable bit being set. 
> umask can prevent this is tree is checkout as one user and build as 
> another user.

Fair enough - i'll queue the patch up.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/