| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20091001085355.GD2181@pengutronix.de> Date: Thu, 1 Oct 2009 10:53:55 +0200 From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> To: Takashi Iwai <tiwai@...e.de> Cc: linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>, Andrew Morton <akpm@...ux-foundation.org>, Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org Subject: Re: [PATCH 06/34] don't use __devexit_p to wrap hal2_remove On Thu, Oct 01, 2009 at 10:36:59AM +0200, Takashi Iwai wrote: > At Thu, 1 Oct 2009 10:28:10 +0200, > Uwe Kleine-König wrote: > > > > The function hal2_remove is defined using __exit, so don't use __devexit_p > > but __exit_p to wrap it. > > I think it's the other way round. We should replace __exit with __devexit. > Ditto for sound/mips/sgio2audio.c. Actually both ways are possible. I choosed the alternative that doesn't add bloat to the kernel. The cost is that the device isn't hotplugable, but you can still unload the module to unbind the driver. I don't care much, but prefer slightly my approach as changing the patch is work for me :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists