linux-kernel - Re: [PATCH 0/9] Add vsprintf extension %pU to print UUID/GUIDs and use it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200910010207.45514.laurent.pinchart@ideasonboard.com>
Date:	Thu, 1 Oct 2009 02:07:45 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Huang Ying <ying.huang@...el.com>
Cc:	Joe Perches <joe@...ches.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...ia.com>,
	Alex Elder <aelder@....com>,
	Artem Bityutskiy <dedekind@...radead.org>,
	Christoph Hellwig <hch@....de>,
	Harvey Harrison <harvey.harrison@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Jeff Garzik <jgarzik@...hat.com>,
	Matt Mackall <mpm@...enic.com>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Neil Brown <neilb@...e.de>,
	Steven Whitehouse <swhiteho@...hat.com>,
	"xfs-masters@....sgi.com" <xfs-masters@....sgi.com>,
	Andi Kleen <andi@...stfloor.org>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH 0/9] Add vsprintf extension %pU to print UUID/GUIDs and use it

On Tuesday 29 September 2009 07:57:32 Huang Ying wrote:
> Hi, Joe,
> 
> Thanks for the patch. I think that is a good idea.
> 
> For your patch. I think you need a changelog for each patch.
> 
> It seems that the binary representation of UUID can be little-endian
> (used by most kernel components) or big-endian (defined by RFC4122, used
> in network?). Maybe we should consider about that.

I think that's what the 'r' option is supposed to handle. Maybe you could use 
'b' and 'l' options instead, to specify the endianness explicitly.

> In fact, I find there are many different UUID/GUID definitions in
> kernel, such as that in efi, many file systems, some drivers, etc. It
> seems that every kernel components need UUID/GUID has its own
> definition, so I think we should unify all the UUID/GUID definitions in
> kernel too. The file attached is a draft unified UUID/GUID definition,
> with byte-order issue in mind.
> 
> Any comment?

Not much, it would help if you could show where those functions would be used.

I would also use the 'le' and 'be' prefixes (as in le16, be32) instead of 'l' 
and 'b', making it leuuid and beuuid, or maybe uuid_le and uuid_be.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/