linux-kernel - Re: [PATCH 10/19] workqueue: update cwq alignement and make one more flag bit available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 01 Oct 2009 17:20:54 +0100
From:	David Howells <dhowells@...hat.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	dhowells@...hat.com, Tejun Heo <tj@...nel.org>, mingo@...e.hu,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	jens.axboe@...cle.com, rusty@...tcorp.com.au,
	cl@...ux-foundation.org, arjan@...ux.intel.com
Subject: Re: [PATCH 10/19] workqueue: update cwq alignement and make one more flag bit available

Jeff Garzik <jeff@...zik.org> wrote:

> The quoted code is a standard kernel technique for creating typed constants
> that are visible to the C compiler (rather than CPP) and debugger.
> 
> It is found in a great many Linux kernel drivers at this point, and is
> definitely not abuse, IMO.

Just because it's common practice, and just because you like it, doesn't make
it not abuse.  But that's a side issue, and fairly irrelevant to the actual
implementation.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/