[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4AC4D93C.4030703@kernel.org>
Date: Fri, 02 Oct 2009 01:30:52 +0900
From: Tejun Heo <tj@...nel.org>
To: David Howells <dhowells@...hat.com>
CC: Jeff Garzik <jeff@...zik.org>, mingo@...e.hu,
linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
jens.axboe@...cle.com, rusty@...tcorp.com.au,
cl@...ux-foundation.org, arjan@...ux.intel.com
Subject: Re: [PATCH 10/19] workqueue: update cwq alignement and make one more
flag bit available
David Howells wrote:
> Jeff Garzik <jeff@...zik.org> wrote:
>
>> The quoted code is a standard kernel technique for creating typed constants
>> that are visible to the C compiler (rather than CPP) and debugger.
>>
>> It is found in a great many Linux kernel drivers at this point, and is
>> definitely not abuse, IMO.
>
> Just because it's common practice, and just because you like it, doesn't make
> it not abuse. But that's a side issue, and fairly irrelevant to the actual
> implementation.
Yeap, that's something I picked up from Jeff while working on libata
and I'm quite fond of it. I haven't encountered any downside of it
yet. Any reason why you think it's an abuse? But, at any rate, yeap,
it's a pretty peripheral issue.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists