linux-kernel - Re: [PATCH] jsm: fixing termios structure to be compatible with stty application

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091001221038.4457e8d6@lxorguk.ukuu.org.uk>
Date:	Thu, 1 Oct 2009 22:10:38 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Breno Leitao <leitao@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jsm: fixing termios structure to be compatible with
 stty application

> Hence, I just assigned ospeed and ispeed with the requested speed in Bfoo
> format (c_flag & CBAUD).

The kernel ospeed and ispeed are not in Bfoo format, they are actual bit
rates. (I've no idea what glibc does, last time I checked it didn't even
support 2007 era Linux speed setting properly so apps still have to use
ioctls directly for them)

> 
> I also tested the tty_termios_encode_baud_rate(), and it will basically do what
> I did:
> 
>         termios->c_ispeed = ibaud;
>         termios->c_ospeed = obaud;
> 
> Thanks for the review, and sorry if I missed the point completely.

ibaud != Bfoo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/