linux-kernel - Re: [PATCH] LED driver for Intel NAS SS4200 series (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1254436662.1799.117.camel@Joe-Laptop.home>
Date:	Thu, 01 Oct 2009 15:37:42 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dave Hansen <dave@...1.net>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>, rpurdie@...ys.net,
	rgirod@...focus.com, Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH] LED driver for Intel NAS SS4200 series (v4)

On Thu, 2009-10-01 at 15:28 -0700, Dave Hansen wrote:
> Changes from last version
> * Changed logging functions to use cleaner helpers
> diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
[]
> +#ifdef pr_fmt
> +#undef pr_fmt
> +#endif
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Hi Dave.

Thanks for doing this.

Minor nit: I think the preferred style is to
put the #define pr_fmt before any #include.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/