linux-kernel - Re: [PATCH] ALSA: ctxfi: Swapped SURROUND-SIDE mute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hws3el548.wl%tiwai@suse.de>
Date:	Fri, 02 Oct 2009 07:47:03 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Sven Eckelmann <sven.eckelmann@....de>
Cc:	Jaroslav Kysela <perex@...ex.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: ctxfi: Swapped SURROUND-SIDE mute

At Thu,  1 Oct 2009 20:06:39 +0200,
Sven Eckelmann wrote:
> 
> On Soundblaster X-FI Titenium with emu20k2 the SIDE and SURROUND mute
> functions are swapped.
> It was checked with 'speaker-test -c 8 -s 3' and (un)mute surround or
> 'speaker-test -c 8 -s 7' and (un)mute side. The volume seems not
> to be affected and works as expected.
> 
> Signed-off-by: Sven Eckelmann <sven.eckelmann@....de>
> ---
> This patch is tested with commit 55fe27f7e2c9d24ce870136bd99ae67b020122d1
> which arranges the channels on emu20k2.

Thanks, applied now.


Takashi

>  sound/pci/ctxfi/ctatc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> index b1b3a64..7545464 100644
> --- a/sound/pci/ctxfi/ctatc.c
> +++ b/sound/pci/ctxfi/ctatc.c
> @@ -1037,7 +1037,7 @@ static int atc_line_front_unmute(struct ct_atc *atc, unsigned char state)
>  
>  static int atc_line_surround_unmute(struct ct_atc *atc, unsigned char state)
>  {
> -	return atc_daio_unmute(atc, state, LINEO4);
> +	return atc_daio_unmute(atc, state, LINEO2);
>  }
>  
>  static int atc_line_clfe_unmute(struct ct_atc *atc, unsigned char state)
> @@ -1047,7 +1047,7 @@ static int atc_line_clfe_unmute(struct ct_atc *atc, unsigned char state)
>  
>  static int atc_line_rear_unmute(struct ct_atc *atc, unsigned char state)
>  {
> -	return atc_daio_unmute(atc, state, LINEO2);
> +	return atc_daio_unmute(atc, state, LINEO4);
>  }
>  
>  static int atc_line_in_unmute(struct ct_atc *atc, unsigned char state)
> -- 
> 1.6.4.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/