linux-kernel - Re: [PATCH 1/1] LIS3LV02D_SPI: Module unload didn't remove sysfs entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4AC5B34E.3080903@tremplin-utc.net>
Date:	Fri, 02 Oct 2009 10:01:18 +0200
From:	Éric Piel <eric.piel@...mplin-utc.net>
To:	Samu Onkalo <samu.p.onkalo@...ia.com>
Cc:	akpm@...ux-foundation.org, daniel@...aq.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] LIS3LV02D_SPI: Module unload didn't remove sysfs
 entry

Op 01-10-09 14:25, Samu Onkalo schreef:
> In module unload, lis3lv02d core driver sysfs clean up was not called.
> 
> Signed-off-by: Samu Onkalo <samu.p.onkalo@...ia.com>
> Acked-by: Daniel Mack <daniel@...aq.de>
Acked-by: Éric Piel <eric.piel@...mplin-utc.net>


> ---
>  drivers/hwmon/lis3lv02d_spi.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/lis3lv02d_spi.c b/drivers/hwmon/lis3lv02d_spi.c
> index ecd7395..82b1680 100644
> --- a/drivers/hwmon/lis3lv02d_spi.c
> +++ b/drivers/hwmon/lis3lv02d_spi.c
> @@ -83,7 +83,8 @@ static int __devexit lis302dl_spi_remove(struct spi_device *spi)
>  	struct lis3lv02d *lis3 = spi_get_drvdata(spi);
>  	lis3lv02d_joystick_disable();
>  	lis3lv02d_poweroff(lis3);
> -	return 0;
> +
> +	return lis3lv02d_remove_fs(&lis3_dev);
>  }
>  
>  #ifdef CONFIG_PM

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/