linux-kernel - Re: [PATCH] trace: fix missing assignment in trace_ctxwake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530910020549q72cbb2fav43c4a6e191239b0c@mail.gmail.com>
Date:	Fri, 2 Oct 2009 14:49:00 +0200
From:	Frédéric Weisbecker <fweisbec@...il.com>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	Steven Rostedt <srostedt@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace: fix missing assignment in trace_ctxwake_*

2009/10/1 Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>:
> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>
> The state char variable S should be reassigned, if S == 0.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>


Good catch, we are indeed missing the state of the task that is going to sleep
for the context switch events (in the raw mode).

Acked-by: Frederic Weisbecker <fweisbec@...il.com>

Fortunately the problem arises with the sched_switch/wake_up  tracers, not
the sched trace events.
The formers are legacy now. But still, that was buggy.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/