linux-kernel - [PATCH 2.6.31.stable] ACPI: Clarify resource conflict message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.0910021048230.25240@localhost.localdomain>
Date:	Fri, 02 Oct 2009 10:51:09 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	stable@...nel.org
Cc:	linux-acpi@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Renninger <trenn@...e.de>,
	Alan Jenkins <sourcejedi.lkml@...glemail.com>,
	Jean Delvare <jdelvare@...e.de>
Subject: [PATCH 2.6.31.stable] ACPI: Clarify resource conflict message

From: Jean Delvare <jdelvare@...e.de>

upstream 14f03343ad1080c2fea29ab2c13f05b976c4584e

>From 14f03343ad1080c2fea29ab2c13f05b976c4584e Mon Sep 17 00:00:00 2001
From: Jean Delvare <jdelvare@...e.de>
Date: Tue, 8 Sep 2009 15:31:46 +0200
Subject: [PATCH] ACPI: Clarify resource conflict message
X-Patchwork-Hint: ignore

The message "ACPI: Device needs an ACPI driver" is misleading. The
device _may_ need an ACPI driver, if the BIOS implemented a custom
API for the device in question (which, AFAIK, can't be checked.) If
not, then either a generic ACPI driver may be used (for example
"thermal"), or nothing can be done (other than a white list).

I propose to reword the message to:

ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver

which I think is more correct. Comments and suggestions welcome.

I also added a message warning about possible problems and system
instability when users pass acpi_enforce_resources=lax, as suggested
by Len.

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Cc: Thomas Renninger <trenn@...e.de>
Cc: Alan Jenkins <sourcejedi.lkml@...glemail.com>
Signed-off-by: Len Brown <len.brown@...el.com>
---
 drivers/acpi/osl.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

Index: linux-2.6.31.y/drivers/acpi/osl.c
===================================================================
--- linux-2.6.31.y.orig/drivers/acpi/osl.c
+++ linux-2.6.31.y/drivers/acpi/osl.c
@@ -1182,7 +1182,13 @@ int acpi_check_resource_conflict(struct 
 			       res_list_elem->name,
 			       (long long) res_list_elem->start,
 			       (long long) res_list_elem->end);
-			printk(KERN_INFO "ACPI: Device needs an ACPI driver\n");
+			if (acpi_enforce_resources == ENFORCE_RESOURCES_LAX)
+				printk(KERN_NOTICE "ACPI: This conflict may"
+				       " cause random problems and system"
+				       " instability\n");
+			printk(KERN_INFO "ACPI: If an ACPI driver is available"
+			       " for this device, you should use it instead of"
+			       " the native driver\n");
 		}
 		if (acpi_enforce_resources == ENFORCE_RESOURCES_STRICT)
 			return -EBUSY;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/