linux-kernel - Re: [PATCH] iSCSI/iBFT: use proper address translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091002012806.GB27478@andromeda.dapyr.net>
Date:	Thu, 1 Oct 2009 21:28:06 -0400
From:	Konrad Rzeszutek <konrad@...nok.org>
To:	Jeremy Fitzhardinge <Jeremy.Fitzhardinge@...rix.com>
Cc:	Jan Beulich <JBeulich@...ell.com>,
	"ketuzsezr@...nok.org" <ketuzsezr@...nok.org>,
	"pjones@...hat.com" <pjones@...hat.com>,
	Martin Wilck <Martin.Wilck@...itsu-siemens.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	alex.zeffertt@...citrix.com
Subject: Re: [PATCH] iSCSI/iBFT: use proper address translation

On Thu, Oct 01, 2009 at 02:46:52PM -0700, Jeremy Fitzhardinge wrote:
> On 10/01/09 01:01, Jan Beulich wrote:
> > In virtual environments (namely, Xen Dom0) virt <-> phys and
> > virt <-> isa-bus translations cannot be freely interchanged. When
> > looking at memory below 1M, the latter translations should always
> > be used.
> >   
> 
> Do you have a different definition for isa_virt_to_bus in your kernel? 
> As far as I can see it is defined to be the same as virt_to_phys.  Also,
> the ISA memory is identity mapped into the domain's physical mapping
> space, so it should be directly accessible without any problems.

The issue as I've come to understand is that the virt_to_phys on
memory below the 1MB does not work. Alex suggested another fix which
ioremap's the iBFT region, but I think this patch by Martin does the same job.

Either way, it looks good to me.

Signed-off-by: Konrad Rzeszutek Wilk <ketuzsezs@...nok.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/