linux-kernel - [PATCH 5/8] omap: iovmm: Add missing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091002224250.11962.58393.stgit@localhost>
Date:	Fri, 02 Oct 2009 15:42:50 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Kevin Hilman <khilman@...prootsystems.com>,
	Hiroshi DOYU <Hiroshi.DOYU@...ia.com>,
	linux-kernel@...r.kernel.org, Julia Lawall <julia@...u.dk>,
	Daniel Walker <dwalker@...o99.com>, linux-omap@...r.kernel.org
Subject: [PATCH 5/8] omap: iovmm: Add missing mutex_unlock

From: Daniel Walker <dwalker@...o99.com>

I was using Coccinelle with the mutex_unlock semantic patch, and it
unconvered this problem. It appears to be a valid missing unlock issue.
This change should correct it by moving the unlock below the label.

This patch is against the mainline kernel.

Cc: Julia Lawall <julia@...u.dk>
Cc: Hiroshi DOYU <Hiroshi.DOYU@...ia.com>
Signed-off-by: Daniel Walker <dwalker@...o99.com>
Signed-off-by: Kevin Hilman <khilman@...prootsystems.com>
Signed-off-by: Tony Lindgren <tony@...mide.com>
---
 arch/arm/plat-omap/iovmm.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 0e5573d..dc3fac3 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -363,8 +363,9 @@ void *da_to_va(struct iommu *obj, u32 da)
 		goto out;
 	}
 	va = area->va;
-	mutex_unlock(&obj->mmap_lock);
 out:
+	mutex_unlock(&obj->mmap_lock);
+
 	return va;
 }
 EXPORT_SYMBOL_GPL(da_to_va);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/