linux-kernel - Re: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl722b.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091002221149.GC32440@kroah.com>
Date:	Fri, 2 Oct 2009 15:11:49 -0700
From:	Greg KH <greg@...ah.com>
To:	Bruce Jones <brucej97223@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org, wfp5@...ginia.edu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: CodingStyle cleanup for
 drivers/acl722b.c

On Mon, Sep 28, 2009 at 02:11:33PM -0700, Bruce Jones wrote:
> Cleanup this file as per the coding style.  Adding KERN_INFO to
> the printks.
> 
> Signed-off-by: Bruce Jones <brucej@...ux.com>
> ---
>  drivers/staging/comedi/drivers/acl7225b.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
> index c3652ef..e6c6c87 100644
> --- a/drivers/staging/comedi/drivers/acl7225b.c
> +++ b/drivers/staging/comedi/drivers/acl7225b.c
> @@ -94,7 +94,7 @@ static int acl7225b_attach(struct comedi_device *dev,
>  
>  	iobase = it->options[0];
>  	iorange = this_board->io_range;
> -	printk("comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
> +	printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
>  	       this_board->name, iobase);
>  	if (!request_region(iobase, iorange, "acl7225b")) {
>  		printk("I/O port conflict\n");
> @@ -137,14 +137,14 @@ static int acl7225b_attach(struct comedi_device *dev,
>  	s->range_table = &range_digital;
>  	s->private = (void *)ACL7225_DI_LO;
>  
> -	printk("\n");
> +	printk(KERN_INFO "\n");

This one change isn't needed, the \n has to be sent as the earlier
printk didn't terminate the line.  I applied it without this change, so
no worries.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/