linux-kernel - Re: [PATCH] connector: Removed the destruct_data callback since it is always kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091004145755.90312e7e.akpm@linux-foundation.org>
Date:	Sun, 4 Oct 2009 14:57:55 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Philipp Reisner <philipp.reisner@...bit.com>
Cc:	Evgeniy Polyakov <zbr@...emap.net>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Lars Ellenberg <lars.ellenberg@...bit.com>
Subject: Re: [PATCH] connector: Removed the destruct_data callback since it
 is always kfree_skb()

On Tue, 29 Sep 2009 16:48:11 +0200 Philipp Reisner <philipp.reisner@...bit.com> wrote:

> Signed-off-by: Philipp Reisner <philipp.reisner@...bit.com>
> Acked-by: Lars Ellenberg <lars.ellenberg@...bit.com>

Please don't send unchangelogged patches.

> index 163c3e3..210338e 100644
> --- a/drivers/connector/cn_queue.c
> +++ b/drivers/connector/cn_queue.c
> @@ -83,8 +83,8 @@ void cn_queue_wrapper(struct work_struct *work)
>  
>  	d->callback(msg, nsp);
>  
> -	d->destruct_data(d->ddata);
> -	d->ddata = NULL;
> +	kfree_skb(d->skb);
> +	d->skb = NULL;
>  
>  	kfree(d->free);
>  }

So..  why is this a good thing to do?  The patchset removes the option
of ever putting anything other than an skb* into the callback data, it
does this without any dicussion or justification and it does it under
the guise of "allowing permission checking in the receiver callbacks".

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/