lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091005100203.GA3211@elte.hu>
Date:	Mon, 5 Oct 2009 12:02:03 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Jayson R. King" <dev@...sonking.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Jiri Kosina <trivial@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: Remove obsolete comment in sched_init()


* Jayson R. King <dev@...sonking.com> wrote:

> Remove the comment about calling alloc_bootmem() as it is not called
> here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.
>
> Signed-off-by: Jayson R. King <dev@...sonking.com>
> ---
>  kernel/sched.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 1535f38..d68ac0e 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9334,10 +9334,6 @@ void __init sched_init(void)
>  #ifdef CONFIG_CPUMASK_OFFSTACK
>         alloc_size += num_possible_cpus() * cpumask_size();
>  #endif
> -       /*
> -        * As sched_init() is called before page_alloc is setup,
> -        * we use alloc_bootmem().
> -        */
>         if (alloc_size) {
>                 ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);

Looks good. The patch is whitespace damaged though (all tabs are spaces) 
- please consult Documentation/email-clients.txt and resend the patch.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ