linux-kernel - Re: [PATCH 02/21] ftrace.c: Add #define pr_fmt(fmt) KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1254748256.13160.0.camel@gandalf.stny.rr.com>
Date:	Mon, 05 Oct 2009 09:10:56 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH 02/21] ftrace.c: Add #define pr_fmt(fmt) KBUILD_MODNAME
 ": " fmt

On Sun, 2009-10-04 at 17:53 -0700, Joe Perches wrote:
> Remove prefixes from pr_<level>, use pr_fmt(fmt)
> No change in output.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  arch/x86/kernel/ftrace.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index 9dbb527..25e6f5f 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -9,6 +9,8 @@
>   * the dangers of modifying code on the run.
>   */
>  
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

What does KBUILD_MODNAME give us in the core code? This file does not
belong to any module and is only compiled into the core kernel.

-- Steve

> +
>  #include <linux/spinlock.h>
>  #include <linux/hardirq.h>
>  #include <linux/uaccess.h>
> @@ -336,15 +338,15 @@ int __init ftrace_dyn_arch_init(void *data)
>  
>  	switch (faulted) {
>  	case 0:
> -		pr_info("ftrace: converting mcount calls to 0f 1f 44 00 00\n");
> +		pr_info("converting mcount calls to 0f 1f 44 00 00\n");
>  		memcpy(ftrace_nop, ftrace_test_p6nop, MCOUNT_INSN_SIZE);
>  		break;
>  	case 1:
> -		pr_info("ftrace: converting mcount calls to 66 66 66 66 90\n");
> +		pr_info("converting mcount calls to 66 66 66 66 90\n");
>  		memcpy(ftrace_nop, ftrace_test_nop5, MCOUNT_INSN_SIZE);
>  		break;
>  	case 2:
> -		pr_info("ftrace: converting mcount calls to jmp . + 5\n");
> +		pr_info("converting mcount calls to jmp . + 5\n");
>  		memcpy(ftrace_nop, ftrace_test_jmp, MCOUNT_INSN_SIZE);
>  		break;
>  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/