lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1254763974.13160.9.camel@gandalf.stny.rr.com>
Date:	Mon, 05 Oct 2009 13:32:54 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH 02/21] ftrace.c: Add #define pr_fmt(fmt) KBUILD_MODNAME
 ": " fmt

On Mon, 2009-10-05 at 10:21 -0700, Joe Perches wrote:
> On Mon, 2009-10-05 at 09:10 -0400, Steven Rostedt wrote:
> > On Sun, 2009-10-04 at 17:53 -0700, Joe Perches wrote:
> > > Remove prefixes from pr_<level>, use pr_fmt(fmt)
> > > No change in output.
> > What does KBUILD_MODNAME give us in the core code? This file does not
> > belong to any module and is only compiled into the core kernel.
> 
> Hi Steven.
> 
> KBUILD_MODNAME is basename(__FILE__), or if multiple files are
> grouped in the Makefile, then it's the basename(group)
> 
> http://lkml.indiana.edu/hypermail/linux/kernel/0210.2/0325.html
> 
> For ftrace.c, it gives "ftrace", which is the same
> as the prefix you were using, so there's no change
> in the output.

If it keeps the same output, and doesn't change when it may be printed,
then you can add my:

Acked-by: Steven Rostedt <rostedt@...dmis.org>

to that one patch.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ