linux-kernel - Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091006075816.GA1362@ucw.cz>
Date:	Tue, 6 Oct 2009 09:58:17 +0200
From:	Pavel Machek <pavel@....cz>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	rpurdie@...ys.net, lenz@...wisc.edu,
	kernel list <linux-kernel@...r.kernel.org>,
	Dirk@...er-Online.de, arminlitzel@....de,
	Cyril Hrubis <metan@....cz>, thommycheck@...il.com,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	dbaryshkov@...il.com, omegamoon@...il.com, eric.y.miao@...il.com,
	utx@...guin.cz, linux-input@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake),
	matrix-keypad related?

Hi!

On Mon 2009-10-05 22:06:50, Dmitry Torokhov wrote:
> On Wed, Sep 30, 2009 at 10:07:46PM +0200, Pavel Machek wrote:
> > 
> > It complains about unbalanced irq 113 wake disable. That one belongs
> > to matrix-keypad...
> 
> I guess some of enable_irq_wake()s fail on your box. Do you see it if
> you apply the patch below?

I'll do short test. But... if you are right, your patch will just make
your machine refuse to suspend... right?

Ungood.

Actually, it seems to break suspend (returns  -EINVAL while refusing
to suspend), warnings are still there, and keyboard is dead after
failed suspend... double plus ungood.

Aha, so warning is solved: the one in the log is from gpio_buttons.

(I wonder if the 'unbalanced irq_wake' warning is useful... who added it?)
 
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

View attachment "1.msg" of type "text/plain" (15254 bytes)