linux-kernel - RE: [PATCH v3] mfd: ADP5520 Multifunction LCD Backlight and KeypadInput Device Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8A42379416420646B9BFAC9682273B6D0E3F46A7@limkexm3.ad.analog.com>
Date:	Tue, 6 Oct 2009 15:32:56 +0100
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	"Mark Brown" <broonie@...nsource.wolfsonmicro.com>
CC:	"Mike Frysinger" <vapier@...too.org>,
	"Samuel Ortiz" <sameo@...ux.intel.com>,
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	<linux-kernel@...r.kernel.org>, "Bryan Wu" <cooloney@...nel.org>
Subject: RE: [PATCH v3] mfd: ADP5520 Multifunction LCD Backlight and KeypadInput Device Driver

>From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
>On Tue, Oct 06, 2009 at 01:55:45PM +0100, Hennerich, Michael wrote:
>> >From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
>
>> >I'm not sure what the association with virtual gpios is?  This is
all
>> >separate to gpiolib except in that it would mean that a gpio driver
for
>> >the device would be able to export these interrupts to its clients.
>
>> This is what I meant.
>> So you propose having the MFD Core as well as its subdevs requesting
the
>> ADP5520 IRQ (client->irq) IRQF_SHARED? I think we already excluded us
>> from using this option when we were asked to move to the NEW threaded
>> irqs?
>
>No, I'm suggesting implementing an IRQ controller driver for the device
>- register an irq_chip for the interrupt controller on it.  Support for
>doing this on I2C devices was added at pretty much the same time as the
>IRQ_ONESHOT support.  This gives access to all the genirq infrastrure
>features rather than having to implement a custom IRQ handling stack.
>
>Like I say, I'm not sure what you meant when you were talking about
>virtual gpios.

This is not an interrupt controller.
The only ADP5520 subdev that needs to be notified is the adp5520-keys
input driver, if present.
Sounds like overshoot, registering a irq_chip using
set_irq_chip_and_handler() and friends, for exactly one dedicated and
known consumer.

-Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/