linux-kernel - Re: [Xen-devel] [PATCH 4/5] x86/fixmap: add a predicate for usermode fixmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ACB90CF.80906@goop.org>
Date:	Tue, 06 Oct 2009 11:47:43 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Jan Beulich <JBeulich@...ell.com>
CC:	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	kurt.hackel@...cle.com, the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Glauber de Oliveira Costa <gcosta@...hat.com>,
	Keir Fraser <keir.fraser@...citrix.com>,
	Zach Brown <zach.brown@...cle.com>,
	Chris Mason <chris.mason@...cle.com>,
	Avi Kivity <avi@...hat.com>
Subject: Re: [Xen-devel] [PATCH 4/5] x86/fixmap: add a predicate for	usermode
 fixmaps

On 10/06/09 03:23, Jan Beulich wrote:
>>>> Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com> 06.10.09 02:50 >>>
>>>>         
>> --- a/arch/x86/include/asm/fixmap.h
>> +++ b/arch/x86/include/asm/fixmap.h
>> @@ -181,6 +181,24 @@ static inline void __set_fixmap(enum fixed_addresses idx,
>>
>> extern void __this_fixmap_does_not_exist(void);
>>
>> +static inline bool user_fixmap(enum fixed_addresses fixmap)
>> +{
>> +	switch (fixmap) {
>> +#ifdef CONFIG_X86_32
>> +	case FIX_HOLE ... FIX_VDSO:
>> +#else
>> +	case VSYSCALL_LAST_PAGE ... VSYSCALL_HPET:
>> +#ifdef CONFIG_PARAVIRT_CLOCK_VSYSCALL
>> +	case FIX_PVCLOCK_TIME_INFO:
>> +#endif
>> +#endif
>> +		return true;
>> +
>> +	default:
>>     
> Isn't that nested #ifdef rather meant to be successive to the 32-/64-bit
> one?
>   

No, because 32-bit doesn't support vsyscall at present.  But I've been
meaning to add a CONFIG_X86_VSYSCALL to make all the vsyscall stuff
conditional on, so if/when 32-bit vsyscall gets done its easy to turn it
all on.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/